dockerfile: use xx-info march when downloading dockerd #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Jul 8, 2023
tonistiigi
reviewed
Jul 8, 2023
| WORKDIR /opt/docker | ||
| RUN DOCKER_ARCH=$(case ${TARGETPLATFORM:-linux/amd64} in \ | ||
| "linux/amd64") echo "x86_64" ;; \ | ||
| "linux/arm/v6") echo "armel" ;; \ |
Member
There was a problem hiding this comment.
Actually this doesn't look correct for arm/vX . https://github.com/tonistiigi/xx/blob/master/base/xx-info#L211 . I'm not sure if this is based on anything? Arm is like debian but aarch64/ppc64le are not debian 😕
Member
Author
There was a problem hiding this comment.
Yes indeed, I recall we had a discussion with @tianon and @thaJeztah to align them in the future.
Member
There was a problem hiding this comment.
In that case, we could still do a case in xx-info with fewer checks than the original, or if you think it's not worth it then we can close this and keep as is.
Member
Author
There was a problem hiding this comment.
Yes let's keep it as is. I'm closing this one and mark it as needs/follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #1897 (comment)