Use buildkit's client.Wait method to bootstrap for remote driver#1934
Merged
jedevc merged 1 commit intodocker:masterfrom Jul 19, 2023
Merged
Use buildkit's client.Wait method to bootstrap for remote driver#1934jedevc merged 1 commit intodocker:masterfrom
client.Wait method to bootstrap for remote driver#1934jedevc merged 1 commit intodocker:masterfrom
Conversation
crazy-max
reviewed
Jul 13, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jedevc
force-pushed
the
use-buildkit-client-wait
branch
from
f6c7a9a to
6bbb83e
Compare
crazy-max
approved these changes
Jul 17, 2023
crazy-max
reviewed
Jul 18, 2023
This native implementation uses GRPC level waiting, instead of starting a busy loop. We also a manual max backoff of one second to improve responsiveness. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
use-buildkit-client-wait
branch
from
6bbb83e to
e11c5e3
Compare
crazy-max
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.