Skip to content

Conversation

@crazy-max
Copy link
Member

relates to

closes #1944

client: define a "dummy" hostname to use for local connections fixes "http: invalid Host header" errors when compiling with go1.20.6 or go1.19.11

full diff: moby/moby@v24.0.2...36e9e79

client: define a "dummy" hostname to use for local connections
fixes "http: invalid Host header" errors when compiling with go1.20.6
or go1.19.11

full diff: moby/moby@v24.0.2...36e9e79

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested review from jedevc and thaJeztah July 17, 2023 08:12
@crazy-max crazy-max marked this pull request as ready for review July 17, 2023 08:12
@crazy-max crazy-max mentioned this pull request Jul 17, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max merged commit a65131f into docker:master Jul 17, 2023
@crazy-max crazy-max deleted the bump-docker branch July 17, 2023 08:29
@thaJeztah
Copy link
Member

FWIW, also opened a backport for moby/moby#45990, which should centralise the logic a bit more, but needs reviews (master and backport)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buildx: ERROR: http: invalid Host header

2 participants