docs: minor cli reference editorial updates#2117
Merged
tonistiigi merged 2 commits intodocker:masterfrom Nov 16, 2023
Merged
Conversation
crazy-max
reviewed
Nov 15, 2023
crazy-max
reviewed
Nov 15, 2023
crazy-max
reviewed
Nov 15, 2023
dvdksn
force-pushed
the
docs-cli-reference-refresh
branch
from
9d676bf to
ab13095
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
docs-cli-reference-refresh
branch
from
5871040 to
8fafdb8
Compare
crazy-max
requested changes
Nov 16, 2023
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Some lint issues otherwise LGTM: https://github.com/docker/buildx/actions/runs/6892599910/job/18750273469?pr=2117#step:4:106
#13 83.37 driver/kubernetes/driver.go:41: File is not `gofmt`-ed with `-s` (gofmt)
#13 83.37 factory driver.Factory
#13 83.37 driver/docker-container/driver.go:43: File is not `gofmt`-ed with `-s` (gofmt)
#13 83.37 factory driver.Factory
#13 ERROR: process "/bin/sh -c golangci-lint run" did not complete successfully: exit code: 1
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
docs-cli-reference-refresh
branch
from
8fafdb8 to
1326634
Compare
tonistiigi
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editorial and formatting updates