deps: update buildkit, vendor changes #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let me also check if moby/buildkit#4496 is good to go |
crazy-max
reviewed
Dec 19, 2023
laurazard
force-pushed
the
bump-buildkit
branch
from
264d3d5 to
434ce5a
Compare
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
force-pushed
the
bump-buildkit
branch
from
434ce5a to
0f45b62
Compare
Contributor
Author
|
PTAL @crazy-max |
crazy-max
approved these changes
Dec 19, 2023
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
LGTM, the metrics exporter introduced by moby/buildkit#4460 will be handled in follow-up (cc @jsternberg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL, they're small changes but I don't really have the context to make sure this is correct.
Related to docker/compose#11283, doing these changes would enable bumping Buildx and Buildkit in Compose to master and solve the OTEL trouble blocking that PR