Skip to content

Conversation

@dunglas
Copy link

@dunglas dunglas commented Jan 31, 2024

Closes #2229.

(*imagetools.Resolver).Copy() can is called in concurrent goroutines.

Because it writes a non-protected map, it sometimes crashes.

Signed-off-by: Kévin Dunglas <kevin@dunglas.fr>
@jedevc
Copy link
Collaborator

jedevc commented Jan 31, 2024

Hey @dunglas thanks for the fix 🎉 🎉 I think I might have beaten you to it sorry! #2230

I'm going to close this one in preference of that one - protecting the map is probably alright, but I think it's better to just avoid modifying one of our inputs in this context at all.

Thanks thanks anyways!

@jedevc jedevc closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"imagetools create" panics when pushing the created image

2 participants