ci(validate): split lint#2439
Merged
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Member
Author
|
Needs to remove "validate (lint)" from required checks in branches protection settings for the repo:
|
tonistiigi
approved these changes
May 1, 2024
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Was also thinking that maybe it would make sense to run the lint target(s) for native arch first and then others in parallel only if first one passed. If linting already wrong for common files then not much point of even running the custom arch variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up moby/buildkit#4829 (comment)
This generates a matrix for each platform for
lintandlint-goplstargets. I think I will port the logic in "Matrix" step to a subaction similar to https://github.com/docker/bake-action?tab=readme-ov-file#list-targets.Reduces build time for the whole pipeline from ~30m:
To ~6m30: