build: retain local and tar exporter attributes#2509
Closed
crazy-max wants to merge 1 commit intodocker:masterfrom
Closed
build: retain local and tar exporter attributes#2509crazy-max wants to merge 1 commit intodocker:masterfrom
crazy-max wants to merge 1 commit intodocker:masterfrom
Conversation
crazy-max
changed the title
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
keep-local-export-attrs
branch
from
5c22ac2 to
8646002
Compare
tonistiigi
reviewed
Jun 11, 2024
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
I'm not sure we should be sending this to buildkit daemon. It is a client local path. If anything, it should be part of localstate.
Member
Author
Yes indeed that's not safe, I'm looking at moving this in localstate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When investigating moby/buildkit#5017 I found that
localandtardidn't have thedestattribute set. I think we should keep it even if not used as we want to keep track of it in the build record.