dap: implement first pass at breakpoints #3302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
dap-breakpoints
branch
2 times, most recently
from
b8075c4 to
11effc3
Compare
Collaborator
Author
|
It turned out to be way easier to reset the breakpoints when they changed during execution than I thought it would be. I thought it would need to be a different PR since I thought it would involve some message passing but it turns out it was just easy to check the breakpoints before each time continue was used. |
ktock
reviewed
Jul 9, 2025
jsternberg
force-pushed
the
dap-breakpoints
branch
2 times, most recently
from
7bc4fb3 to
5db46fd
Compare
tonistiigi
reviewed
Jul 11, 2025
Implement the first iteration of breakpoints. When a breakpoint is set, it starts unverified. When a thread begins evaluation, it tries to see if a breakpoint corresponds to one of the parsed instructions and will verify it. Breakpoints work when continue is used. At the current moment, setting breakpoints while a thread is currently running doesn't work. Breakpoints are rechecked each time execution is about to restart. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
dap-breakpoints
branch
from
5db46fd to
0dddf0a
Compare
tonistiigi
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the first iteration of breakpoints. When a breakpoint is set,
it starts unverified. When a thread begins evaluation, it tries to see
if a breakpoint corresponds to one of the parsed instructions and will
verify it.
Breakpoints work when continue is used.
At the current moment, setting breakpoints while a thread is currently
running doesn't work. Breakpoints are rechecked each time execution is
about to restart.