dap: alias step into to next and step out to continue #3309
Conversation
dap/adapter.go
Outdated
| subReq.Arguments.ThreadId = req.Arguments.ThreadId | ||
| subReq.Arguments.SingleThread = req.Arguments.SingleThread | ||
|
|
||
| if err := d.Continue(c, &subReq, &subResp); err != nil { |
There was a problem hiding this comment.
Implementation looks good to me.
But if there is no concept like step-in and step-out in dockerfile, maybe leaving them as nop is enough ?
There was a problem hiding this comment.
They show up in the visual studio code UI and don't seem to be behind a capability so I thought aliasing them was probably easiest for now. If also like to get done feedback from users about how they feel these buttons should work.
If it doesn't make sense we can leave it out but I figured that step in is the equivalent of next anyway if there's no function and step out is the equivalent of continue if you consider llb to be one big main function.
There was a problem hiding this comment.
Thanks for the explanation, making them as aliases sounds good to me.
jsternberg
force-pushed
the
dap-step-into
branch
from
0a74290 to
7a7fe63
Compare
Step into and step out are required by the UI for DAP. We don't have a way to implement these in a logical manner but they need to exist. We'll discuss in further iterations how these might differ from next and continue, but for now, we just need some implementation for the UI. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
dap-step-into
branch
from
7a7fe63 to
0a78659
Compare
3 participants
Step into and step out are required by the UI for DAP. We don't have a
way to implement these in a logical manner but they need to exist. We'll
discuss in further iterations how these might differ from next and
continue, but for now, we just need some implementation for the UI.