Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
213 changes: 206 additions & 7 deletions commands/imagetools/create.go
Original file line number Diff line number Diff line change
@@ -1,27 +1,226 @@
package commands

import (
"encoding/json"
"fmt"
"io/ioutil"
"strings"

"github.com/docker/cli/cli/command"
"github.com/docker/distribution/reference"
"github.com/moby/buildkit/util/appcontext"
"github.com/opencontainers/go-digest"
ocispec "github.com/opencontainers/image-spec/specs-go/v1"
"github.com/pkg/errors"
"github.com/spf13/cobra"
"github.com/tonistiigi/buildx/util/imagetools"
"golang.org/x/sync/errgroup"
)

type createOptions struct {
files []string
tags []string
dryrun bool
append bool
files []string
tags []string
dryrun bool
actionAppend bool
}

func runCreate(dockerCli command.Cli, in createOptions, args []string) error {
return errors.Errorf("not-implemented")
if len(args) == 0 && len(in.files) == 0 {
return errors.Errorf("no sources specified")
}

if !in.dryrun && len(in.tags) == 0 {
return errors.Errorf("can't push with no tags specified, please set --tag or --dry-run")
}

fileArgs := make([]string, len(in.files))
for i, f := range in.files {
dt, err := ioutil.ReadFile(f)
if err != nil {
return err
}
fileArgs[i] = string(dt)
}

args = append(fileArgs, args...)

tags, err := parseRefs(in.tags)
if err != nil {
return err
}

if in.actionAppend && len(in.tags) > 0 {
args = append([]string{in.tags[0]}, args...)
}

srcs, err := parseSources(args)
if err != nil {
return err
}

repos := map[string]struct{}{}

for _, t := range tags {
repos[t.Name()] = struct{}{}
}

sourceRefs := false
for _, s := range srcs {
if s.Ref != nil {
repos[s.Ref.Name()] = struct{}{}
sourceRefs = true
}
}

if len(repos) == 0 {
return errors.Errorf("no repositories specified, please set a reference in tag or source")
}
if len(repos) > 1 {
return errors.Errorf("multiple repositories currently not supported, found %v", repos)
}

var repo string
for r := range repos {
repo = r
}

for i, s := range srcs {
if s.Ref == nil && s.Desc.MediaType == "" && s.Desc.Digest != "" {
n, err := reference.ParseNormalizedNamed(repo)
if err != nil {
return err
}
r, err := reference.WithDigest(n, s.Desc.Digest)
if err != nil {
return err
}
srcs[i].Ref = r
sourceRefs = true
}
}

ctx := appcontext.Context()

r := imagetools.New(imagetools.Opt{
Auth: dockerCli.ConfigFile(),
})

if sourceRefs {
eg, ctx2 := errgroup.WithContext(ctx)
for i, s := range srcs {
if s.Ref == nil {
continue
}
func(i int) {
eg.Go(func() error {
_, desc, err := r.Resolve(ctx2, srcs[i].Ref.String())
if err != nil {
return err
}
srcs[i].Ref = nil
srcs[i].Desc = desc
return nil
})
}(i)
}
if err := eg.Wait(); err != nil {
return err
}
}

descs := make([]ocispec.Descriptor, len(srcs))
for i := range descs {
descs[i] = srcs[i].Desc
}

dt, desc, err := r.Combine(ctx, repo, descs)
if err != nil {
return err
}

if in.dryrun {
fmt.Printf("%s\n", dt)
return nil
}

// new resolver cause need new auth
r = imagetools.New(imagetools.Opt{
Auth: dockerCli.ConfigFile(),
})

for _, t := range tags {
if err := r.Push(ctx, t, desc, dt); err != nil {
return err
}
fmt.Println(t.String())
}

return nil
}

type src struct {
Desc ocispec.Descriptor
Ref reference.Named
}

func parseSources(in []string) ([]*src, error) {
out := make([]*src, len(in))
for i, in := range in {
s, err := parseSource(in)
if err != nil {
return nil, errors.Wrapf(err, "failed to parse source %q, valid sources are digests, refereces and descriptors", in)
}
out[i] = s
}
return out, nil
}

func parseRefs(in []string) ([]reference.Named, error) {
refs := make([]reference.Named, len(in))
for i, in := range in {
n, err := reference.ParseNormalizedNamed(in)
if err != nil {
return nil, err
}
refs[i] = n
}
return refs, nil
}

func parseSource(in string) (*src, error) {
// source can be a digest, reference or a descriptor JSON
dgst, err := digest.Parse(in)
if err == nil {
return &src{
Desc: ocispec.Descriptor{
Digest: dgst,
},
}, nil
} else if strings.HasPrefix(in, "sha256") {
return nil, err
}

ref, err := reference.ParseNormalizedNamed(in)
if err == nil {
return &src{
Ref: ref,
}, nil
} else if !strings.HasPrefix(in, "{") {
return nil, err
}

var s src
if err := json.Unmarshal([]byte(in), &s.Desc); err != nil {
return nil, errors.WithStack(err)
}
return &s, nil
}

func createCmd(dockerCli command.Cli) *cobra.Command {
var options createOptions

cmd := &cobra.Command{
Use: "create [OPTIONS] [SOURCE...]",
Use: "create [OPTIONS] [SOURCE] [SOURCE...]",
Short: "Create a new image based on source images",
RunE: func(cmd *cobra.Command, args []string) error {
return runCreate(dockerCli, options, args)
Expand All @@ -33,7 +232,7 @@ func createCmd(dockerCli command.Cli) *cobra.Command {
flags.StringArrayVarP(&options.files, "file", "f", []string{}, "Read source descriptor from file")
flags.StringArrayVarP(&options.tags, "tag", "t", []string{}, "Set reference for new image")
flags.BoolVar(&options.dryrun, "dry-run", false, "Show final image instead of pushing")
flags.BoolVar(&options.append, "append", false, "Append to existing manifest")
flags.BoolVar(&options.actionAppend, "append", false, "Append to existing manifest")

_ = flags

Expand Down
Loading