ci: use kind for e2e tests #979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Collaborator
|
Could you explain pros/cons? |
Member
Author
|
Found out you were using kind while implementing the kubernetes driver in #167 so I wanted to check its behavior in our CI. pros are we could use kind in a container in a follow-up so we don't need to rely on the "kind action" on GHA. WDYT? |
Collaborator
|
I feel k3s is closer to production clusters, but no strong opinion. @tonistiigi @ktock WDYT? |
Collaborator
|
Sorry for the late reply.
I feel so too but not a strong opinion.
Maybe "k3s in Docker" can also be used? : https://github.com/k3d-io/k3d |
Member
Author
|
Looking at your comments it seems better to keep the current behavior for now. Thanks for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com