make orchestrator verify line number before posting comment#41
Merged
derekmisler merged 1 commit intodocker:mainfrom Feb 13, 2026
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
Contributor
Author
|
/describe |
|
✅ PR description has been generated and updated! |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
No issues found! The changes add appropriate instructions for line number verification with reasonable safeguards:
✅ Step renumbering is correct (6→6, 7→7, 8)
✅ New "Verify Line Numbers" section provides clear guidance with fallback mechanisms
✅ grep permission correctly added to allow the verification process
The PR successfully addresses the reliability of line number verification in review comments.
rumpl
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a comment posted by the agent was off by a couple of lines. This will help, I think.
Summary
Adds a mandatory line number verification step to the PR review orchestrator to prevent posting inline comments on incorrect lines. The orchestrator now uses
grepto verify line numbers against the actual file content before posting comments, addressing unreliability in LLM-computed line numbers from diffs.Changes
grep -nto confirm line numbers before posting inline comments, with instructions on handling ambiguous matches. Updated workflow steps to include verification before building comments. Addedgreppermission to allowed shell commands.Breaking Changes
None
How to Test
grep -ncommands to validate line numbers before posting