make aliased agent paths absolute#1607
Merged
krissetto merged 1 commit intodocker:mainfrom Feb 5, 2026
Merged
Conversation
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
rumpl
approved these changes
Feb 5, 2026
dgageot
approved these changes
Feb 5, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ No issues found
The changes correctly handle relative path resolution for local file aliases:
- Properly checks if the path is NOT an OCI reference
- Properly checks if the path is NOT a URL reference
- Only converts to absolute path if it's a relative local file path
- Includes appropriate error handling
The code compiles, passes lint checks, and all tests pass. The logic is sound and the implementation is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.