-
Notifications
You must be signed in to change notification settings - Fork 250
Support for the .agents/skills standard
#1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+480
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent return value types - may return relative path in error case while returning absolute path in success case
The
projectSearchDirsfunction has an inconsistency: whenfilepath.Absfails (line 98), it returns[]string{cwd}which could be a relative path, but whengitRootis empty (line 105), it returns[]string{absPath}which is an absolute path.While this doesn't cause immediate functional failures because
filepath.Joinandos.ReadDirboth handle relative and absolute paths, it represents a logic inconsistency that violates the function's implicit contract. The comment on lines 89-92 says "returns directories" without specifying absolute vs relative.This inconsistency could cause subtle issues with path handling, logging, or if the paths are later used in contexts that expect absolute paths.
Suggestion: Return
[]string{absPath}in the error case on line 98 as well, or return an empty slice[]string{}ifAbsfails, rather than returning the potentially relativecwd. This would maintain consistency that all returned paths are absolute.