Merged
Conversation
rumpl
previously approved these changes
Feb 5, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
Found 1 issue that should be addressed:
Medium Severity
- Context cancellation error handling doesn't reset loading state, which can leave the UI stuck showing "Loading…" when file loading is cancelled
The rest of the code looks good! The async loading implementation is well-structured with proper context handling and goroutine cleanup.
…dirs Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
fast-at-attach
branch
from
8a459f8 to
926ac8c
Compare
dgageot
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And get fs browsing off the render thread, so we don't hang the TUI in large or deeply nested dirs
When running the TUI in my home
~/dir, cpu would get pinned, ram would be eaten up and the whole TUI would lock upScreencasts
before:
Screencast.From.2026-02-05.14-32-10.mp4
after:
Screencast.From.2026-02-05.14-34-04.mp4