Add a generalist coding agent

[dgageot]

No description provided.

[github-actions]

Review Summary

Found one bug in the new BuiltinAgentNames() function that causes non-deterministic ordering in shell completions. The function iterates over a map without sorting, which will cause agent names to appear in random order each time users invoke shell completion.

✅ The rest of the PR looks good - clean refactoring to support multiple built-in agents.

[rumpl]

There is no context7 mcp server config

[rumpl]

maybe we can filter the fs tools and give it only what's needed. For example do we need the "search file" and "search file contents" tools if it has a shell

[dgageot]

I'll give it a try

[krissetto]

Just thinking out loud here..

Since this will be shipped as a built-in agent and not just an example or sorts, i kinda feel like we should make this general coding assistant much more "fully featured", with some sort of plan build review type of flow, or at least having the agent team pre-configured to be able to do so. just having an opus + haiku thing just doesn't seem very useful to me.

Also, I've never really seen the golang_developer agent in our delegate to the librarian (not a good name imho) if not for silly prompts that had nothing to do with coding, so is it even worth it to include it? just give opus the tool since it has literally everything else

Honestly i don't know if shipping this as is will be super valuable to most users who enjoy using defaults, as it only caters to anthropic users and doesn't really seem like it'd be good at doing its job with so many different tasks in the system prompt if not relying on some of the best models out there (aka opus).

Definitely don't wanna block this, just throwin' out some food for though if we want to provide a "proper" coding agent as a built-in thing. We can definitely iterate on it over time

[rumpl]

Also, I've never really seen the golang_developer agent in our delegate to the librarian

By design, up to the user to tell the coder to use it, I like it like that

librarian (not a good name imho)

Stole it from Amp

[krissetto]

Stole it from Amp

What is Amp? 🧌

By design, up to the user to tell the coder to use it, I like it like that

If the user doesn't know about it and its purpose, because its a default, what percentage of users do you think would ask? 😛

[dgageot]

@krissetto @rumpl Like you, I see this as a starting point. Let's iterate after the merge to make this default coding agent awesome