Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🎯 Review Summary
This PR correctly implements the no_audio build tag to disable audio functionality. All build constraint changes are logically sound and properly structured.
✅ What was reviewed:
- Build tag logic in darwin and stub implementations
- Complementary build constraints for mutual exclusion
- Docker build flag addition
📋 Findings:
No issues found. The changes correctly implement conditional compilation:
- Darwin audio implementations excluded when
no_audiois set - Stub implementations used for non-darwin OR when
no_audiois set - Build tags are mutually exclusive and complete
Great work on the implementation! 🚀
krissetto
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.