OpenAI doesn't like those format indications on the schema#1650
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 9, 2026
Merged
OpenAI doesn't like those format indications on the schema#1650dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
Found one potential issue with the removeFormatFields() implementation. The function only removes format fields from top-level properties but doesn't handle nested objects or array items. While current tests don't demonstrate nested schemas with format fields, the implementation is incomplete for deeply nested structures.
✅ Good additions:
- Clear function documentation explaining why format fields need removal
- Proper nil and missing properties handling
- Comprehensive test coverage for flat schemas
- Function doesn't recursively handle nested objects or array items
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
fix-mcp-fetch
branch
from
8809d35 to
a80d342
Compare
krissetto
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.