fix: use alt modifier for session browser shortcuts to avoid search conflict#1653
Closed
rumpl wants to merge 1 commit intodocker:mainfrom
Closed
fix: use alt modifier for session browser shortcuts to avoid search conflict#1653rumpl wants to merge 1 commit intodocker:mainfrom
rumpl wants to merge 1 commit intodocker:mainfrom
Conversation
…onflict Plain 's', 'f', and 'c' keys were intercepted by the star, filter, and copy-id actions before reaching the search text input, making it impossible to search for sessions containing those characters. Change the key bindings to alt+s, alt+f, and alt+c so that unmodified key presses are forwarded to the search input as expected. Fixes docker#1642 Assisted-By: cagent Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ No issues found!
The changes look good. The PR correctly updates the key bindings from plain s, f, and c to alt+s, alt+f, and alt+c to avoid conflicts with the search input field. The implementation is:
- Syntactically correct: Uses the proper key binding syntax for the bubbles/key library
- Consistent: Both the key binding definitions and help text are updated consistently
- Well-aligned with the fix: Solves the stated problem in issue #1642 by allowing unmodified keys to reach the search input
Nice fix! 🎉
krissetto
reviewed
Feb 9, 2026
Contributor
krissetto
left a comment
krissetto
left a comment
There was a problem hiding this comment.
have you tested this on mac? i remember alt combos being problematic with macOS capturing them and printing chars like ß instead
Member
|
@rumpl lol, I implemented the search field before the shortcuts but never used it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain
s,f, andckeys were intercepted by the star, filter, and copy-id actions before reaching the search text input, making it impossible to search for sessions containing those characters.Change the key bindings to
alt+s,alt+f, andalt+cso that unmodified key presses are forwarded to the search input as expected.Fixes #1642