Refactor scrollbar into more reusable scrollview component#1654
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 9, 2026
Merged
Refactor scrollbar into more reusable scrollview component#1654dgageot merged 1 commit intodocker:mainfrom
scrollview component#1654dgageot merged 1 commit intodocker:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review Summary
Found 2 issues in the scrollview refactoring:
- High severity: Double
EnsureLineVisiblecall can hide part of selected messages - Medium severity: Mouse hit-testing has 1-frame lag after position changes in dialogs
See inline comments for details.
c70199f to
4545c95
Compare
also fixes some minor scrollbar positioning and ux bugs in certain scenarios when dragging the scrollbar with a mouse Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
4545c95 to
e33beca
Compare
dgageot
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things: