Merged
Conversation
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
pasted-attachments-fix
branch
from
a60fae8 to
00c6b45
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ Approved - No issues found
This PR successfully refactors attachment handling from map[string]string to a structured []messages.Attachment type. The changes are well-designed:
- Clear separation between file-reference attachments (FilePath set) and inline content attachments (Content set)
- Proper error handling and context cancellation throughout
- Intentional temp file cleanup for paste attachments
- Early path resolution to absolute paths prevents working directory issues
The code is clean, well-commented, and the tests have been updated appropriately.
Member
|
Same for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.