Merged
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review: Fix tick leak
Summary
The core fix (changing animSub from value to pointer type) correctly addresses the tick leak issue. However, I found some concerns with the defensive nil-check code added in Init().
Findings
- 1 Medium severity issue: The nil-check in
Init()doesn't work as intended due to value receiver semantics - 1 Medium severity issue: The test doesn't validate the nil-check defensive code
Recommendation
The main bug fix is sound, but the defensive nil-checks have issues. Since New() always initializes animSub properly, consider either:
- Using a pointer receiver for
Init()to make the nil-check work correctly - Removing the nil-checks and documenting that zero-value Spinners are unsupported
- Keeping as-is if zero-value Spinners are never created in practice
Given that all usage appears to go through New(), the current code will work correctly in practice.
The animation subscription was a value, that got copied so Stop()ing would stop a copied subscription resulting in ~10% CPU usage once the assistant finished answering and nothing was moving on the screen. Make sure that all the spinners share the same animation subscription Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
dgageot
approved these changes
Feb 10, 2026
dgageot
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animation subscription was a value, that got copied so Stop()ing would stop a copied subscription resulting in ~10% CPU usage once the assistant finished answering and nothing was moving on the screen.
Make sure that all the spinners share the same animation subscription