-
Notifications
You must be signed in to change notification settings - Fork 251
Fix A2A agent card advertising unroutable wildcard address #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+48
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package a2a | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestRoutableAddr(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| addr string | ||
| want string | ||
| }{ | ||
| {"ipv6 wildcard", "[::]:8080", "localhost:8080"}, | ||
| {"ipv4 wildcard", "0.0.0.0:8080", "localhost:8080"}, | ||
| {"empty host", ":8080", "localhost:8080"}, | ||
| {"localhost stays", "localhost:8080", "localhost:8080"}, | ||
| {"ipv4 loopback stays", "127.0.0.1:8080", "127.0.0.1:8080"}, | ||
| {"specific ip stays", "192.168.1.1:9090", "192.168.1.1:9090"}, | ||
| {"hostname stays", "my-host:8080", "my-host:8080"}, | ||
| {"invalid addr returned as-is", "not-a-host-port", "not-a-host-port"}, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| assert.Equal(t, tt.want, routableAddr(tt.addr)) | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential Breaking Change: IPv6 Support Removed
Changing from
"tcp"to"tcp4"restricts socket binding to IPv4 only. While this aligns with the PR description ("avoid binding to IPv6 on dual-stack systems"), it introduces a breaking change:[::1]:8080or[2001:db8::1]:8080, binding will fail with a cryptic error:"listen tcp4: address ::1: no suitable address found"routableAddr()tests include IPv6 cases ("[::]:8080"), suggesting IPv6 was considered in the designAlternative approach: Consider keeping
"tcp"for backward compatibility and letroutableAddr()handle the agent card URL transformation. This would:If tcp4 is the desired approach: Consider adding validation to detect IPv6 addresses and return a clear error message like "IPv6 addresses are not supported, please use IPv4".
Thoughts?