Remove redundant stdin nil check in api command#1688
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 11, 2026
Merged
Conversation
The stdin variable is a copy of os.Stdin captured before it's set to nil, and os.Stdin is virtually always non-nil. The check provided no real protection and could confuse maintainers. Fixes docker#1665 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ Approved - This is a good code cleanup that removes a redundant nil check.
The change correctly removes the && stdin != nil check because:
- The
stdinvariable is a copy ofos.Stdincaptured beforeos.Stdinis set to nil (line 93) - The Go runtime virtually always initializes
os.Stdinto a valid value - As issue #1665 correctly identified, the check was "potentially misleading" rather than protective
- The check would only matter if
os.Stdinwere already nil at program start, which doesn't happen in practice
The removal makes the code clearer by eliminating a check that appears to guard against a condition that doesn't occur. No real bugs were found in the changed code.
rumpl
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stdin variable is a copy of os.Stdin captured before it's set to nil, and os.Stdin is virtually always non-nil. The check provided no real protection and could confuse maintainers.
Fixes #1665