Skip to content

Add the summary message as a user message #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rumpl merged 1 commit into from
Feb 11, 2026
Merged

Add the summary message as a user message #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/session/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ func buildSessionSummaryMessages(s *Session) ([]chat.Message, int) {

if lastSummaryIndex >= 0 && lastSummaryIndex < len(s.Messages) {
messages = append(messages, chat.Message{
Role: chat.MessageRoleSystem,
Role: chat.MessageRoleUser,
Content: "Session Summary: " + s.Messages[lastSummaryIndex].Summary,
CreatedAt: time.Now().Format(time.RFC3339),
})
Expand Down
8 changes: 4 additions & 4 deletions pkg/session/session_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,17 +149,17 @@ func TestGetMessagesWithSummary(t *testing.T) {
if msg.Role == chat.MessageRoleUser || msg.Role == chat.MessageRoleAssistant {
userAssistantMessages++
}
if msg.Role == chat.MessageRoleSystem && msg.Content == "Session Summary: This is a summary of the conversation so far" {
if msg.Role == chat.MessageRoleUser && msg.Content == "Session Summary: This is a summary of the conversation so far" {
summaryFound = true
}
}

// We should have:
// - 1 summary system message
// - 1 summary user message
// - 2 messages after the summary (user + assistant)
// - Various other system messages from agent setup
assert.True(t, summaryFound, "should include summary as system message")
assert.Equal(t, 2, userAssistantMessages, "should only include messages after summary")
assert.True(t, summaryFound, "should include summary as user message")
assert.Equal(t, 3, userAssistantMessages, "should only include messages after summary")
}

func TestGetMessages_Instructions(t *testing.T) {
Expand Down