Improve error handling and logging in evaluation judge#1706
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 12, 2026
Merged
Improve error handling and logging in evaluation judge#1706dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
- Propagate stream errors instead of silently ignoring non-EOF errors - Return idiomatic (passed, reason, error) from parseJudgeResponse instead of a custom struct with a parsed bool - Add structured logging for parse failures and successful responses - Wrap JSON parse errors with fmt.Errorf for proper error chaining Assisted-by: cagent
There was a problem hiding this comment.
Review Summary
✅ Code looks good! No issues found in the changed code.
The PR successfully improves error handling:
- Stream errors are properly propagated instead of being silently ignored
- The function signature change to
(passed, reason, error)is idiomatic Go - Error wrapping with
fmt.Errorfprovides proper error chains - Structured logging adds helpful observability for debugging
All test cases align with the implementation and error paths are correctly handled.
trungutt
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: cagent