fix: recursively enforce required properties in OpenAI tool schemas#1710
Merged
dgageot merged 2 commits intodocker:mainfrom Feb 13, 2026
Merged
fix: recursively enforce required properties in OpenAI tool schemas#1710dgageot merged 2 commits intodocker:mainfrom
dgageot merged 2 commits intodocker:mainfrom
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Summary
✅ Approved
This PR successfully refactors the schema processing to recursively enforce required properties throughout nested JSON schemas, which fixes the Chrome MCP integration with OpenAI 5.2.
Changes Reviewed
New walkSchema function:
- Cleanly abstracts the recursive traversal logic
- Properly handles properties, anyOf/oneOf/allOf variants, and array items
- Uses safe comma-ok idiom for all type assertions
- No risk of infinite recursion (JSON structures are acyclic)
Refactored makeAllRequired:
- Now processes all nested schema nodes, not just top-level
- Correctly marks newly-required properties as nullable
- Maintains sorted order for deterministic output
Refactored removeFormatFields:
- Simplified to use
walkSchemahelper - More maintainable and consistent
Testing
Comprehensive test coverage added for:
- anyOf variants with nested required fields ✓
- Nested object properties ✓
- Array items with required fields ✓
The refactoring is sound and well-tested. No issues found.
Signed-off-by: David Gageot <david.gageot@docker.com>
Fixes Chrome MCP with openai 5.2 Signed-off-by: David Gageot <david.gageot@docker.com>
rumpl
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Chrome MCP with openai 5.2