Conversation
trungutt
previously approved these changes
Feb 16, 2026
krissetto
reviewed
Feb 16, 2026
Contributor
krissetto
left a comment
krissetto
left a comment
There was a problem hiding this comment.
i'm a bit confused, why would we need a fallback for an older store? wouldn't it be better to make sure the interface is satisfied at compile time so the issue won'r happen again? (had put a similar fix in my tab pr after rebasing on main with the issue haha)
Member
|
I have no idea what is going on here or how it fixes the commit you linked |
Member
Author
|
@krissetto I'll TAL. I honestly didn't look at the commit |
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
fix-slash-models
branch
from
ea7d716 to
25f263f
Compare
Member
Author
|
@krissetto @rumpl I pushed a better fix |
rumpl
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been broken by e3eb713