Allow to use cagent binary as a docker cli plugin docker-agent. No functional change for cagent command.

[gtardif]

• Added task for local docker cli plugin deployment: task deploy-local
• ./bin/cagent (or .exe on windows) works exactly as before
• we can now use docker agent as a replacement for the cagent command, with no other changes:
  docker agent run ...

 docker agent --help
Usage:  docker agent [OPTIONS] COMMAND

create or run AI agents

Examples:
  docker agent run ./agent.yaml
  docker agent run agentcatalog/pirate
...

[docker-agent]

Review Summary

🔍 Found 1 high-severity and 1 medium-severity issue in the added code.

Critical Issue

• Line 41: The condition len(os.Args) >= 0 is always true and can cause a panic if os.Args is empty. Should be len(os.Args) > 0.

Additional Issue

• Line 164: The context passed to Execute() is not propagated to plugin.Run(), so context cancellation won't work in plugin mode.

Please review the inline comments for details.

[docker-agent]

🔴 HIGH SEVERITY: Logic error - always true condition can cause panic

The condition len(os.Args) >= 0 is always true since slice length cannot be negative. More critically, if os.Args is empty (length 0), accessing os.Args[0] will cause a panic (index out of range).

Fix: Change the condition to len(os.Args) > 0 to ensure os.Args[0] is accessible:

return len(os.Args) > 0 && strings.HasSuffix(os.Args[0], cliPluginBinary)

While os.Args is typically guaranteed to have at least one element in normal execution, it can be empty in test scenarios or if manipulated, making this a real risk.

[docker-agent]

⚠️ MEDIUM SEVERITY: Context not propagated to plugin.Run()

The ctx parameter passed to Execute() is not used in the plugin path. In the non-plugin path (line 186), rootCmd.ExecuteContext(ctx) properly propagates the context. However, in the plugin path, the context is never passed to or used by plugin.Run().

Impact: Context cancellation, timeouts, and other context-based operations won't work when running as a CLI plugin. This creates inconsistent behavior between plugin and non-plugin execution modes.

Suggested fix: Consider calling rootCmd.SetContext(ctx) before passing it to the plugin callback, or investigate if the Docker CLI plugin framework provides a way to pass context.