bash completion of plugins overwrites files

[smilingthax]

Description

The bash auto-completion function for plugins __docker_complete_plugin calls eval here: https://github.com/docker/cli/blob/master/contrib/completion/bash/docker#L1161
But when ${resultArray[*]} contains shell output redirections, files will be created/overwritten just by pressing !

Reproduce

In a bash shell w/ docker auto completion enabled, and a plugin installed, e.g. scan (or compose, ...) type (no after !):

testdir$ ls
testdir$ docker scan > Test2
testdir$ ls
Test Test2
testdir$
With ${resultArray[*]} :

/usr/libexec/docker/cli-plugins/docker-scan __completeNoDesc > Test
and
/usr/libexec/docker/cli-plugins/docker-scan __completeNoDesc > Test2

Expected behavior

The files Test and Test2 should not have been written to.
They are even overwritten, should they have existed before...

docker version

Client: Docker Engine - Community
 Version:           23.0.4
 API version:       1.42
 Go version:        go1.19.8
 Git commit:        f480fb1
 Built:             Fri Apr 14 10:36:38 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          23.0.4
  API version:      1.42 (minimum version 1.12)
  Go version:       go1.19.8
  Git commit:       cbce331
  Built:            Fri Apr 14 10:34:14 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.20
  GitCommit:        2806fc1057397dbaeefbea0e4e17bddfbd388f38
 runc:
  Version:          1.1.5
  GitCommit:        v1.1.5-0-gf19387a
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info

Client:
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.10.4
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.17.2
    Path:     /usr/libexec/docker/cli-plugins/docker-compose
  scan: Docker Scan (Docker Inc.)
    Version:  v0.23.0
    Path:     /usr/libexec/docker/cli-plugins/docker-scan

Server:
 Containers: 23
  Running: 20
  Paused: 0
  Stopped: 3
 Images: 71
 Server Version: 23.0.4
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 2806fc1057397dbaeefbea0e4e17bddfbd388f38
 runc version: v1.1.5-0-gf19387a
 init version: de40ad0
 Security Options:
  seccomp
   Profile: builtin
 Kernel Version: 6.3.0-1.el7.elrepo.x86_64
 Operating System: CentOS Linux 7 (Core)
 OSType: linux
 Architecture: x86_64
 CPUs: 8
 Total Memory: 31.21GiB

Additional Info

bash --version
GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu)
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html

[thaJeztah]

• Looks like this code was originally introduced (it moved around a few times and received some updates after) in 1148163 (Add completion for docker-compose plugin #3158)

[thaJeztah]

closing as this this went stale, and we now switched to use the cobra-generated completion scripts by default