Remove Kubernetes commands from experimental #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/kubernetes
impact/changelog
kind/experimental
and removed
status/0-triage
labels
mat007
approved these changes
May 20, 2018
vdemeester
approved these changes
May 25, 2018
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐯
Let's wait for the required PR to get merge before merging this one though 👼
silvin-lubecki
changed the title
silvin-lubecki
force-pushed
the
remove-experimental-for-orchestrator
branch
from
271acef to
72fdc36
Compare
Contributor
Author
|
Rebased |
thaJeztah
requested changes
May 28, 2018
| }, | ||
| { | ||
| doc: "kubernetesConfigFile", | ||
| configfile: `{ |
Member
There was a problem hiding this comment.
Looks like there's a couple more "experimental": "enabled" below; think those can be removed as well?
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubecki
force-pushed
the
remove-experimental-for-orchestrator
branch
from
72fdc36 to
f2b75a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I removed the experimentalCli annotations and all the experimental code linked to the Kubernetes features.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
