Skip to content

[18.06] build: --iidfile support with buildkit#1185

Merged
andrewhsu merged 1 commit into
docker:18.06from
tiborvass:18.06-cp
Jul 5, 2018
Merged

[18.06] build: --iidfile support with buildkit#1185
andrewhsu merged 1 commit into
docker:18.06from
tiborvass:18.06-cp

Conversation

@tiborvass
Copy link
Copy Markdown
Collaborator

@tiborvass tiborvass commented Jul 3, 2018

cherry-pick of #1176 for 18.06

Signed-off-by: Tibor Vass tibor@docker.com
(cherry picked from commit c7e85c0)
Signed-off-by: Tibor Vass tibor@docker.com

first needs docker-archive/engine#7

Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit c7e85c0)
Signed-off-by: Tibor Vass <tibor@docker.com>
Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah
Copy link
Copy Markdown
Member

docker-archive/engine#7 was merged; is this good to go?

@tiborvass tiborvass changed the title [18.06] [WIP] build: --iidfile support with buildkit [18.06] build: --iidfile support with buildkit Jul 5, 2018
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 9fbab75 into docker:18.06 Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants