Skip to content

Add bash completion for service create|update --init #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 1 commit into from
Jul 13, 2018
Merged

Add bash completion for service create|update --init #1210

thaJeztah merged 1 commit into from
Jul 13, 2018

Conversation

@albers
Copy link
Collaborator

@albers albers commented Jul 13, 2018

This adds bash completion for #479.

@albers
Add bash completion for service create|update --init
97d312e 
Signed-off-by: Harald Albers <github@albersweb.de>
@albers albers added this to the 18.06.0 milestone Jul 13, 2018
vdemeester
vdemeester approved these changes Jul 13, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

thaJeztah
thaJeztah approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit d97f378 into docker:master Jul 13, 2018
@albers albers deleted the completion-service-create--init branch July 13, 2018 08:09
@thaJeztah thaJeztah mentioned this pull request Jul 13, 2018
Merged
@thaJeztah thaJeztah modified the milestones: 18.06.0, 18.09.0 Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@silvin-lubecki silvin-lubecki Awaiting requested review from silvin-lubecki

Assignees

No one assigned

Labels

area/completion process/cherry-picked status/2-code-review

Projects

None yet

Milestone

18.09.0

Development

Successfully merging this pull request may close these issues.

4 participants

@albers @vdemeester @thaJeztah @GordonTheTurtle