Add bash completion for service logs --details|--raw#1215
Merged
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
=======================================
Coverage 54.25% 54.25%
=======================================
Files 268 268
Lines 17796 17796
=======================================
Hits 9656 9656
Misses 7533 7533
Partials 607 607 |
thaJeztah
approved these changes
Jul 31, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM ❤️, thanks for the ping, I missed this one
Collaborator
Author
|
@thaJeztah that was kinda fast, thanks! |
Member
|
I'll have a look at cherry picking as well when I get back to my computer; we may just as well include it if there may be a patch release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found two missing options in docker service logs' bash completion.