Skip to content

Remove outdated completion reviewers file#1256

Merged
vdemeester merged 1 commit into
docker:masterfrom
silvin-lubecki:update-reviewers
Aug 1, 2018
Merged

Remove outdated completion reviewers file#1256
vdemeester merged 1 commit into
docker:masterfrom
silvin-lubecki:update-reviewers

Conversation

@silvin-lubecki
Copy link
Copy Markdown
Contributor

Clean maintainers and code owners files

- A picture of a cute animal (not mandatory but encouraged)

image

Clean maintainers and code owners files

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

Comment thread .github/CODEOWNERS
# See https://github.com/blog/2392-introducing-code-owners

cli/command/stack/** @vdemeester
cli/command/stack/** @vdemeester @silvin-lubecki
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@@ -1,2 +0,0 @@
Tianon Gravi <admwiggin@gmail.com> (@tianon)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianon ❤️

@@ -1,2 +0,0 @@
Tianon Gravi <admwiggin@gmail.com> (@tianon)
Jessie Frazelle <jess@docker.com> (@jfrazelle)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessfraz ❤️

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 1, 2018

Codecov Report

Merging #1256 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files         268      268           
  Lines       17809    17809           
=======================================
  Hits         9658     9658           
  Misses       7543     7543           
  Partials      608      608

@vdemeester vdemeester merged commit 2093fd6 into docker:master Aug 1, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.09.0 milestone Aug 1, 2018
@silvin-lubecki silvin-lubecki deleted the update-reviewers branch August 2, 2018 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants