Fix shellcheck warnings#1271
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
6a0194f to
e587ec2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 54.29% 54.29%
=======================================
Files 268 268
Lines 17855 17855
=======================================
Hits 9695 9695
Misses 7550 7550
Partials 610 610 |
silvin-lubecki
left a comment
There was a problem hiding this comment.
LGTM. I don't know shellcheck, but do you think we could add a CI check which fails if it complains?
|
@silvin-lubecki We already have this check, it's the ci/circleci: shellcheck check that's always executed in this repo. You can manually execute it with Not all shellcheck recommendations make sense in the context of bash completion, e.g. we construct awk commands that contain a literal When the checks were introduced in #266, quite a lot of exceptions were added in order to get it running. In this PR I remove some of them. |
Fixed some problems identified by shellcheck.