Skip to content

Conversation

@olljanat
Copy link
Contributor

- What I did
Bump docker to f76d6a078d881f410c00e8d900dcdfc2e026c841

Needed by #1410

- A picture of a cute animal (not mandatory but encouraged)
c3

Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1593 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1593   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files         283      283           
  Lines       19305    19305           
=======================================
  Hits        10682    10682           
  Misses       7927     7927           
  Partials      696      696

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1593 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1593   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files         283      283           
  Lines       19305    19305           
=======================================
  Hits        10682    10682           
  Misses       7927     7927           
  Partials      696      696

@olljanat
Copy link
Contributor Author

@thaJeztah @vdemeester PTAL

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github.com/containerd/containerd aa5e000c963756778ab3ebd1a12c67449c503a34 # v1.2.1+
github.com/containerd/fifo 3d5202aec260678c48179c56f40e6f38a095738c
github.com/containerd/continuity bd77b46c8352f74eb12c85bdc01f4b90f69d66b4
github.com/containerd/continuity 004b46473808b3e7a4a3049c20e4376c91eb966d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I looked at this PR, and wanted to check if we needed to update these as well (as they're out of date), but I can bring it in sync with containerd in #1561

@thaJeztah thaJeztah merged commit 143028e into docker:master Jan 4, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants