-
Notifications
You must be signed in to change notification settings - Fork 2.1k
added note about shorter command 'docker build' #1703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please sign your commits following these rules: $ git clone -b "patch-1" git@github.com:thadguidry/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Codecov Report
@@ Coverage Diff @@
## master #1703 +/- ##
=======================================
Coverage 56.12% 56.12%
=======================================
Files 306 306
Lines 21030 21030
=======================================
Hits 11803 11803
Misses 8373 8373
Partials 854 854 |
This will help clarify to users that they are the same command. As well as make it clear in the auto-generated docs https://docs.docker.com/engine/reference/commandline/image_build/ Signed-off-by: Thad Guidry <thadguidry@gmail.com>
|
Thank you for your contribution but this is not specific to build, so we'd need to either make it consistent across all aliased commands or decide not to take it, sorry! |
|
That's unfortunate because it was a question asked by 3 independent Ericsson developers towards our Devops group and I had to explain this to them and puzzled why they didn't know...they said... "their docs really didn't explain that well, thanks for explaining to us Thad." |
|
@thadguidry I'm not against clarifying that if that's confusing. I just think other commands need the same adjustments "docker container run |
|
@tiborvass @thaJeztah As the documentation be updated yet? Can i work on this i would love to kindly provide input or pointers. |
|
|
||
| Commands: | ||
| build Build an image from a Dockerfile | ||
| build Build an image from a Dockerfile (same as 'docker build') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example shows the output how the CLI itself prints it, which does not include this).
We added additional metadata, and usage output in these PR's though (and will be using those in the documentation);
|
closing this per above, but thanks for contributing! |
- What I did
Documentation Improvement
- How I did it
This will help clarify to users that they are the same command.
As well as make it clear in the auto-generated docs https://docs.docker.com/engine/reference/commandline/image_build/
- How to verify it
- Description for the changelog
Added note to 'docker image build' about shorter syntax 'docker build'