use latest golang:1.8 image to cross compile #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
40 tasks
Contributor
Author
|
Looks like @StefanScherer beat me to the punch. Closing this PR in favor of #173 |
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 45.33% 45.33%
=======================================
Files 171 171
Lines 11480 11480
=======================================
Hits 5204 5204
Misses 5979 5979
Partials 297 297 |
trapier
pushed a commit
to trapier/cli
that referenced
this pull request
Sep 30, 2019
…-19.03-208de55a179591fc4941b25191922ac302d024f4 [19.03] sync to upstream 19.03 208de55
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.07] backport Changing the get network request to...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Hsu andrewhsu@docker.com
- What I did
Latest golang 1.8 version is 1.8.3. The cross compile Dockerfile locks it to 1.8.1. This PR will float the image version to latest of golang:1.8
- How I did it
Change FROM line.
- How to verify it
$ make -f docker.Makefile crossAnd see that
Go versionis 1.8.3 withdocker.exe version- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐌