Bump Golang 1.12.3 and fix: nolint directive#1820
Closed
thaJeztah wants to merge 2 commits intodocker:masterfrom
Closed
Bump Golang 1.12.3 and fix: nolint directive#1820thaJeztah wants to merge 2 commits intodocker:masterfrom
thaJeztah wants to merge 2 commits intodocker:masterfrom
Conversation
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #1820 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 308 308
Lines 21429 21429
=======================================
Hits 12068 12068
Misses 8476 8476
Partials 885 885 |
thaJeztah
changed the title
Member
Author
|
LOL; and removing it also says it isn't right 😂 Closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #1818 (comment)
carries #1818
closes #1818
let's see if current go version doesn't complain without this statement 🤷♂️