Reformat vendor.conf and pin all deps by git-sha#1822
Merged
vdemeester merged 2 commits intodocker:masterfrom Apr 12, 2019
Merged
Reformat vendor.conf and pin all deps by git-sha#1822vdemeester merged 2 commits intodocker:masterfrom
vdemeester merged 2 commits intodocker:masterfrom
Conversation
To make it better readable, and to encourage pinning by sha, but "align" to a tagged release. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @vdemeester @silvin-lubecki PTAL |
Codecov Report
@@ Coverage Diff @@
## master #1822 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 308 308
Lines 21429 21429
=======================================
Hits 12068 12068
Misses 8476 8476
Partials 885 885 |
silvin-lubecki
approved these changes
Apr 12, 2019
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
Totally agree with this PR !
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jun 20, 2019
To make it better readable, and to encourage pinning by sha, but "align" to a tagged release. similar to 6026ce4 (docker#1822) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jul 23, 2019
To make it better readable, and to encourage pinning by sha, but "align" to a tagged release. similar to 6026ce4 (docker#1822) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to make it better readable, and to encourage pinning by sha, but "align" to a tagged release.
Also sorted the list again