[19.03 backport] Introduce .zip import for docker context#1912
Merged
thaJeztah merged 1 commit intodocker:19.03from May 29, 2019
Merged
[19.03 backport] Introduce .zip import for docker context#1912thaJeztah merged 1 commit intodocker:19.03from
thaJeztah merged 1 commit intodocker:19.03from
Conversation
Adds capabilities to import a .zip file with importZip. Detects the content type of source by checking bytes & DetectContentType. Adds LimitedReader reader, a fork of io.LimitedReader, was needed for better error messaging instead of just getting back EOF. We are using limited reader to avoid very big files causing memory issues. Adds a new file size limit for context imports, this limit is used for the main file for .zip & .tar and individual compressed files for .zip. Added TestImportZip that will check the import content type Then will assert no err on Importing .zip file Signed-off-by: Goksu Toprak <goksu.toprak@docker.com> (cherry picked from commit 291e862) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @tiborvass @goksu PTAL |
goksu
approved these changes
May 29, 2019
Contributor
goksu
left a comment
goksu
left a comment
There was a problem hiding this comment.
Looks good to me, all changes are here as well.
Codecov Report
@@ Coverage Diff @@
## 19.03 #1912 +/- ##
==========================================
+ Coverage 56.67% 56.69% +0.01%
==========================================
Files 309 310 +1
Lines 21707 21778 +71
==========================================
+ Hits 12303 12346 +43
- Misses 8505 8519 +14
- Partials 899 913 +14 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 19.03 #1912 +/- ##
==========================================
+ Coverage 56.67% 56.69% +0.01%
==========================================
Files 309 310 +1
Lines 21707 21778 +71
==========================================
+ Hits 12303 12346 +43
- Misses 8505 8519 +14
- Partials 899 913 +14 |
tiborvass
approved these changes
May 29, 2019
Member
Author
|
thanks! merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #1895 for 19.03
Adds capabilities to import a .zip file with importZip.
Detects the content type of source by checking bytes & DetectContentType.
Adds LimitedReader reader, a fork of io.LimitedReader,
was needed for better error messaging instead of just getting back EOF.
We are using limited reader to avoid very big files causing memory issues.
Adds a new file size limit for context imports,
this limit is used for the main file for .zip & .tar and individual compressed
files for .zip.
Added TestImportZip that will check the import content type
Then will assert no err on Importing .zip file
Signed-off-by: Goksu Toprak goksu.toprak@docker.com
(cherry picked from commit 291e862)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)