Skip to content

fix: docker login autocomplete for zsh#1948

Merged
vdemeester merged 1 commit into
docker:masterfrom
rhnvrm:patch-1
Jun 25, 2019
Merged

fix: docker login autocomplete for zsh#1948
vdemeester merged 1 commit into
docker:masterfrom
rhnvrm:patch-1

Conversation

@rhnvrm
Copy link
Copy Markdown
Contributor

@rhnvrm rhnvrm commented Jun 14, 2019

- What I did

Changed --user to --username

- How I did it

Edited zsh autocomplete file

- How to verify it

You can use zsh and press tab after typing docker login --

- Description for the changelog

Fix for docker login username flag in zsh autocomplete

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:rhnvrm/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Changed `--user` to `--username`

Signed-off-by: Rohan Verma <hello@rohanverma.net>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1948 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1948   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files         310      310           
  Lines       21800    21800           
=======================================
  Hits        12367    12367           
  Misses       8518     8518           
  Partials      915      915

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester ptal

Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants