Skip to content

Nvidia gpu access#1974

Merged
thaJeztah merged 1 commit into
docker:masterfrom
adrian-plata:nvidia-gpu
Jul 10, 2019
Merged

Nvidia gpu access#1974
thaJeztah merged 1 commit into
docker:masterfrom
adrian-plata:nvidia-gpu

Conversation

@adrian-plata
Copy link
Copy Markdown
Contributor

@adrian-plata adrian-plata commented Jun 27, 2019

Adding how to access NVIDIA gpu resources

@adrian-plata adrian-plata requested a review from thaJeztah as a code owner June 27, 2019 17:30
@GordonTheTurtle

This comment has been minimized.

Sign in to view
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 27, 2019 •
edited
Loading

Codecov Report

Merging #1974 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1974      +/-   ##
==========================================
- Coverage   56.74%   56.72%   -0.02%     
==========================================
  Files         310      310              
  Lines       21802    21800       -2     
==========================================
- Hits        12371    12367       -4     
- Misses       8517     8518       +1     
- Partials      914      915       +1

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 27, 2019

Codecov Report

Merging #1974 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1974      +/-   ##
==========================================
- Coverage   56.74%   56.72%   -0.02%     
==========================================
  Files         310      310              
  Lines       21801    21800       -1     
==========================================
- Hits        12370    12367       -3     
- Misses       8517     8518       +1     
- Partials      914      915       +1

@RenaudWasTaken
Copy link
Copy Markdown
Contributor

RenaudWasTaken commented Jun 28, 2019

Pretty cool, thanks for the commit!
I've just finished working on our docs for the NVIDIA Container Toolkit (new name): NVIDIA/nvidia-docker#996

Do you mind:

  • Mentioning that you need to install the NVIDIA Container Toolkit (and maybe link to the repo?)
  • You probably want to use CUDA images, otherwise you'll have to specify a compute capability
  • Signing-off your commits :D

AkihiroSuda
AkihiroSuda reviewed Jun 30, 2019
View reviewed changes
Comment thread docs/reference/commandline/run.md Outdated
@adrian-plata
Copy link
Copy Markdown
Contributor Author

adrian-plata commented Jul 1, 2019

@thaJeztah PTAL

@RenaudWasTaken
Copy link
Copy Markdown
Contributor

RenaudWasTaken commented Jul 1, 2019

The only thing that's missing here is that if you use the ubuntu image, you need to specify on the CLI:
docker run --gpus 'all,capabilities=utility' --rm ubuntu nvidia-smi

@adrian-plata
Copy link
Copy Markdown
Contributor Author

adrian-plata commented Jul 2, 2019

@RenaudWasTaken We'll be adding that information to another location in the docs.

@RenaudWasTaken
Copy link
Copy Markdown
Contributor

RenaudWasTaken commented Jul 3, 2019 •
edited
Loading

Sorry forget my previous comment, I forgot that if no capabilities are set we (the nvidia-container-cli) default to utility.

thaJeztah
thaJeztah requested changes Jul 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions; could you also squash and sign-off the commits before we merge?

Comment thread docs/reference/commandline/run.md Outdated
Comment thread docs/reference/commandline/run.md Outdated
@adrian-plata
adding nvidia gpu access info
f7b75ee 
Signed-off-by: Adrian Plata <adrian.plata@docker.com>

Removing prerequisites section.
Signed-off-by: Adrian Plata <adrian.plata@docker.com>

Removing prerequisites section.
Signed-off-by: Adrian Plata <adrian.plata@docker.com>

adding nvidia gpu access info
Signed-off-by: Adrian Plata <adrian.plata@docker.com>

Refining information.

Removing prerequisites section.

adding nvidia gpu access info
Signed-off-by: Adrian Plata <adrian.plata@docker.com>

Refining information.

Removing prerequisites section.

adding nvidia gpu access info
Signed-off-by: Adrian Plata <adrian.plata@docker.com>

Refining information.

Removing prerequisites section.
@adrian-plata
Copy link
Copy Markdown
Contributor Author

adrian-plata commented Jul 9, 2019

@tiborvass PTAL. After that, I think @thaJeztah can merge.

thaJeztah
thaJeztah approved these changes Jul 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit f6860e6 into docker:master Jul 10, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Jul 10, 2019
@thaJeztah thaJeztah mentioned this pull request Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@tiborvass tiborvass tiborvass approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@RenaudWasTaken RenaudWasTaken RenaudWasTaken left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/docs process/cherry-picked status/3-docs-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

7 participants

@adrian-plata @GordonTheTurtle @codecov-io @RenaudWasTaken @tiborvass @thaJeztah @AkihiroSuda