Skip to content

[19.03 backport] bump docker-credential-helpers v0.6.3#1983

Merged
andrewhsu merged 2 commits intodocker:19.03from
thaJeztah:19.03_backport_bump_credential_helpers
Aug 8, 2019
Merged

[19.03 backport] bump docker-credential-helpers v0.6.3#1983
andrewhsu merged 2 commits intodocker:19.03from
thaJeztah:19.03_backport_bump_credential_helpers

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 4, 2019

backport of #1935 and #2006

full diff: docker/docker-credential-helpers@5241b46...8a9f93a

includes:

bump to v0.6.3:

full diff: docker/docker-credential-helpers@v0.6.2...v0.6.3

full diff: docker/docker-credential-helpers@5241b46...8a9f93a

includes:

- docker/docker-credential-helpers#29 C.free(unsafe.Pointer(err)) -> C.g_error_free(err)
- docker/docker-credential-helpers#124 pass: changed the way for checking if password-store is initalized
  - addresses docker/docker-credential-helpers#133 docker-credential-pass commits about 10 times every time I run a docker command
- docker/docker-credential-helpers#143 Fix docker-credential-osxkeychain list behaviour in case of missing entry in keychain
- docker/docker-credential-helpers#139 make docker-credential-wincred work like docker-credential-osxkeychain

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit f6a4c76)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #1983 into 19.03 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            19.03    #1983   +/-   ##
=======================================
  Coverage   56.71%   56.71%           
=======================================
  Files         310      310           
  Lines       21789    21789           
=======================================
  Hits        12357    12357           
  Misses       8519     8519           
  Partials      913      913

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

full diff: docker/docker-credential-helpers@v0.6.2...v0.6.3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 64f0ae4)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title [19.03 backport] bump docker-credential-helpers v0.6.2 [19.03 backport] bump docker-credential-helpers v0.6.3 Jul 17, 2019
@thaJeztah thaJeztah modified the milestones: 19.03.1, 19.03.2 Jul 26, 2019
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants