[18.09 backport] bump docker-credential-helpers v0.6.3#1984
Merged
thaJeztah merged 2 commits intodocker:18.09from Aug 8, 2019
Merged
[18.09 backport] bump docker-credential-helpers v0.6.3#1984thaJeztah merged 2 commits intodocker:18.09from
thaJeztah merged 2 commits intodocker:18.09from
Conversation
Codecov Report
@@ Coverage Diff @@
## 18.09 #1984 +/- ##
=======================================
Coverage 54.29% 54.29%
=======================================
Files 291 291
Lines 19459 19459
=======================================
Hits 10565 10565
Misses 8214 8214
Partials 680 680 |
ada7ce0 to
76c6467
Compare
Member
Author
|
rebased |
Member
Author
|
Interesting; e2e fails with: https://jenkins.dockerproject.org/job/docker/job/cli/job/PR-1984/4/console But the test should be running using the docker socket; |
full diff: docker/docker-credential-helpers@5241b46...8a9f93a includes: - docker/docker-credential-helpers#29 C.free(unsafe.Pointer(err)) -> C.g_error_free(err) - docker/docker-credential-helpers#124 pass: changed the way for checking if password-store is initalized - addresses docker/docker-credential-helpers#133 docker-credential-pass commits about 10 times every time I run a docker command - docker/docker-credential-helpers#143 Fix docker-credential-osxkeychain list behaviour in case of missing entry in keychain - docker/docker-credential-helpers#139 make docker-credential-wincred work like docker-credential-osxkeychain Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit f6a4c76) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: docker/docker-credential-helpers@v0.6.2...v0.6.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 64f0ae4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
76c6467 to
ea2b474
Compare
kolyshkin
approved these changes
Aug 8, 2019
Contributor
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM (given that CI is green)
Member
Author
|
all green now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"WIP" because this is based on top of #1961backport of #1935 and #2006
full diff: docker/docker-credential-helpers@5241b46...8a9f93a
includes:
bump v0.6.3:
full diff: docker/docker-credential-helpers@v0.6.2...v0.6.3