Faster CI#206
Conversation
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 48.93% 48.93%
=======================================
Files 177 177
Lines 11846 11846
=======================================
Hits 5797 5797
Misses 5687 5687
Partials 362 362 |
dnephin
force-pushed
the
why-cross-so-slow
branch
from
4f80ed2 to
425673b
Compare
dnephin
force-pushed
the
why-cross-so-slow
branch
2 times, most recently
from
882d719 to
7ec790c
Compare
dnephin
force-pushed
the
why-cross-so-slow
branch
from
7ec790c to
0718d63
Compare
|
I cleaned up the |
| RUN /tmp/osx-cross.sh | ||
| ENV PATH /osxcross/target/bin:$PATH | ||
|
|
||
| FROM dnephin/golang-cross@sha256:3a23c1791a8f9bb4a79e2708b2a87b51502ef24315170ed0fc27baa056c1a862 |
There was a problem hiding this comment.
should we try to get this in the dockercore org? I think we used that for other images used during build/ci; https://hub.docker.com/u/dockercore/
There was a problem hiding this comment.
We can still decide to keep the dockerfile for building it in this repository
There was a problem hiding this comment.
I'd be happy to move the image to dockercore, what org should receive the github repo?
I don't think we should keep a copy here if it's not used by CI. Keeping around files that aren't actually used just causes confusion. If someone needs to make a change they can go to the source repo.
We pin an exact digest here, so upgrades are easy.
There was a problem hiding this comment.
@tiborvass do you know if we already have a general purpose git repo for base images used in CI?
We could move the golang-cross Dockerfile to that repo, if one exists.
Reusable docker engine Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
force-pushed
the
why-cross-so-slow
branch
from
0718d63 to
1eb66d6
Compare
|
Ok, this is now using the |
|
ping for another review |
[17.06] bump version to 17.06.2-ce-rc1
5 participants
Runtime is now under 3min (from ~9min)