Skip to content

Adding docs for "overlay2.size" storage-opt#215

Merged
thaJeztah merged 1 commit into
docker:masterfrom
imkin:default-max-size-param-doc
Jun 28, 2017
Merged

Adding docs for "overlay2.size" storage-opt#215
thaJeztah merged 1 commit into
docker:masterfrom
imkin:default-max-size-param-doc

Conversation

@imkin
Copy link
Copy Markdown
Contributor

@imkin imkin commented Jun 20, 2017

Docs for change moby/moby#32977
And issue moby/moby#30491

Signed-off-by: Dhawal Yogesh Bhanushali dbhanushali@vmware.com

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 20, 2017

Codecov Report

Merging #215 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   46.85%   46.84%   -0.01%     
==========================================
  Files         172      172              
  Lines       11692    11692              
==========================================
- Hits         5478     5477       -1     
- Misses       5902     5903       +1     
  Partials      312      312

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted one typo, but LGTM after that's fixed

also ping @vdemeester PTAL

Comment thread docs/reference/commandline/dockerd.md Outdated
###### Example

```bash
$ sudo dockerd -s overaly2 --storage-opt overlay2.size=1G
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, typo; s/overaly2/overlay2

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fixed the typo

Signed-off-by: Dhawal Yogesh Bhanushali <dbhanushali@vmware.com>
@imkin imkin force-pushed the default-max-size-param-doc branch from f2c2556 to ff2552f Compare June 28, 2017 06:59
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 0ec3e8a into docker:master Jun 28, 2017
albers added a commit to albers/docker-cli that referenced this pull request Jul 3, 2017
This adds bash completion for
- docker#215
- moby/moby#32977

Signed-off-by: Harald Albers <github@albersweb.de>
andrewhsu pushed a commit to docker-archive/docker-ce that referenced this pull request Jul 14, 2017
This adds bash completion for
- docker/cli#215
- moby/moby#32977

Signed-off-by: Harald Albers <github@albersweb.de>
Upstream-commit: a4b1769bb600edf9c7542247fccc3e7dae074da0
Component: cli
alshabib pushed a commit to alshabib/cli that referenced this pull request Aug 1, 2017
This adds bash completion for
- docker#215
- moby/moby#32977

Signed-off-by: Harald Albers <github@albersweb.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants