Fix lint errors merged while new lint branch was in PR#221
Merged
vdemeester merged 1 commit intodocker:masterfrom Jun 23, 2017
Merged
Fix lint errors merged while new lint branch was in PR#221vdemeester merged 1 commit intodocker:masterfrom
vdemeester merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 45.75% 45.73% -0.02%
==========================================
Files 171 171
Lines 11527 11531 +4
==========================================
Hits 5274 5274
- Misses 5946 5950 +4
Partials 307 307 |
|
LGTM, but curious why this doesn't seem to be failing other PRs. Are the new linters not running on the whole codebase in each PR? |
Contributor
Author
|
It's because of this alecthomas/gometalinter#299. I'm going to look at getting a fix into gometalinter for that soon. |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.09] cli updated vendoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a panic in
gosimplewhich is why thenewAttachchange is being reverted and whitelisted for now. It was fixed in dominikh/go-tools@769824f so we just have to pickup that fix in gometalinters vendored copy. I will do that tomorrow.The other 2 were from PRs that were merged at the same time as the new linter PR, so the new linters had never run on them.